PMD Results

The following document contains the results of PMD 5.6.1.

Files

org/apache/log4j/chainsaw/ApplicationPreferenceModel.java

Violation Line
Useless parentheses. 196

org/apache/log4j/chainsaw/ApplicationPreferenceModelPanel.java

Violation Line
Avoid empty catch blocks 97
Avoid empty catch blocks 103
Useless qualified this usage in the same class. 429
Avoid empty if statements 695–699

org/apache/log4j/chainsaw/ChainsawAppender.java

Violation Line
Avoid empty catch blocks 131–132

org/apache/log4j/chainsaw/ChainsawAppenderHandler.java

Violation Line
Useless parentheses. 257
Useless parentheses. 257
Useless parentheses. 317
Useless parentheses. 338

org/apache/log4j/chainsaw/ChainsawCyclicBufferTableModel.java

Violation Line
Useless parentheses. 332
Useless parentheses. 588
Useless parentheses. 588
Useless parentheses. 588
Useless parentheses. 591
Useless parentheses. 591
Useless parentheses. 591
Useless parentheses. 594
Useless parentheses. 594
Useless parentheses. 594
Useless parentheses. 597
Useless parentheses. 597
Useless parentheses. 597
Useless parentheses. 658
Useless parentheses. 658
Avoid unused local variables such as 'increment'. 873

org/apache/log4j/chainsaw/ColumnComparator.java

Violation Line
Useless parentheses. 55
Useless parentheses. 123
Useless parentheses. 175
Useless parentheses. 175
Useless parentheses. 175
Useless parentheses. 177
Useless parentheses. 178
Useless parentheses. 178

org/apache/log4j/chainsaw/CyclicBufferList.java

Violation Line
Useless parentheses. 126
Useless parentheses. 126
Useless parentheses. 187

org/apache/log4j/chainsaw/EventBatchListener.java

Violation Line
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 47

org/apache/log4j/chainsaw/EventCountListener.java

Violation Line
Avoid modifiers which are implied by the context 29

org/apache/log4j/chainsaw/ExpressionRuleContext.java

Violation Line
Useless parentheses. 97
Useless parentheses. 113
These nested if statements could be combined 128–130
Useless parentheses. 138
Useless parentheses. 139
Useless parentheses. 190
Useless parentheses. 190–191
Useless parentheses. 191
Useless parentheses. 209
Useless parentheses. 209
Useless parentheses. 240
Useless parentheses. 240

org/apache/log4j/chainsaw/FileLoadAction.java

Violation Line
Avoid empty catch blocks 88–90

org/apache/log4j/chainsaw/FileSaveAction.java

Violation Line
Useless parentheses. 100
Useless parentheses. 100
Useless parentheses. 100
Useless parentheses. 100
Avoid empty catch blocks 132–134

org/apache/log4j/chainsaw/GeneratorBeanInfo.java

Violation Line
Avoid empty catch blocks 39–40

org/apache/log4j/chainsaw/JSortTable.java

Violation Line
Useless parentheses. 98
Useless parentheses. 98
Avoid empty catch blocks 111–113
Useless parentheses. 131

org/apache/log4j/chainsaw/LogFilePatternLayoutBuilder.java

Violation Line
Avoid empty if statements 145–147
Avoid empty catch blocks 155–157
Avoid empty catch blocks 157–159
Avoid empty catch blocks 159–161
Avoid empty catch blocks 164–166
Avoid empty catch blocks 219–220
These nested if statements could be combined 251–288

org/apache/log4j/chainsaw/LogPanel.java

Violation Line
Useless parentheses. 742
Useless parentheses. 742
Useless parentheses. 747
Useless parentheses. 898
Useless parentheses. 898–899
Useless parentheses. 899
Useless parentheses. 899
Useless parentheses. 902
Useless parentheses. 902
Useless parentheses. 903
Useless parentheses. 916
Useless parentheses. 928
Useless parentheses. 928–929
Useless parentheses. 929
Useless parentheses. 929
Avoid empty catch blocks 1012
These nested if statements could be combined 1017–1022
Useless parentheses. 1071
Useless parentheses. 1377
Useless parentheses. 1379
Useless parentheses. 1665
Useless parentheses. 1956
These nested if statements could be combined 2201–2203
Avoid empty catch blocks 2249–2250
Avoid empty catch blocks 2326
Avoid empty catch blocks 2412
Useless parentheses. 2436
Useless parentheses. 2437
Useless parentheses. 2628
Useless parentheses. 2628
Useless parentheses. 2994
These nested if statements could be combined 3183–3188
Useless parentheses. 3323
Avoid empty if statements 3383–3387
Avoid empty if statements 3402–3406
Useless parentheses. 3511
Useless parentheses. 3512
Useless parentheses. 3544
Useless parentheses. 3544
Useless parentheses. 3652
Useless parentheses. 3652
Avoid empty catch blocks 3673
Useless parentheses. 3678
Avoid empty catch blocks 3690
Useless parentheses. 3740
Useless parentheses. 3904
Useless parentheses. 3913
Useless parentheses. 3923
Useless parentheses. 3980
These nested if statements could be combined 3989–3999
Useless parentheses. 3990
These nested if statements could be combined 4007–4022
Useless parentheses. 4008
Useless parentheses. 4028
Useless parentheses. 4034
Useless parentheses. 4114
Useless parentheses. 4114
Useless parentheses. 4121
Useless parentheses. 4121
Useless parentheses. 4134
Useless parentheses. 4134
Useless parentheses. 4141
Useless parentheses. 4141
Useless parentheses. 4318
Useless parentheses. 4439

org/apache/log4j/chainsaw/LogPanelPreferenceModel.java

Violation Line
Useless parentheses. 246
Useless parentheses. 346
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 365
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 365
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 370
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 370

org/apache/log4j/chainsaw/LogUI.java

Violation Line
Avoid empty if statements 294–296
Useless parentheses. 342
Useless parentheses. 420
Useless parentheses. 900
Useless parentheses. 901
Useless parentheses. 905
Useless parentheses. 906
Useless parentheses. 953
Useless parentheses. 954
These nested if statements could be combined 1250–1254
Useless parentheses. 1250
Useless parentheses. 1250
Useless parentheses. 1251
Useless parentheses. 1251
Useless parentheses. 1252–1253
Useless parentheses. 1359
Useless parentheses. 1362
Avoid empty catch blocks 1585–1587
Useless parentheses. 1608
Useless parentheses. 1609
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 1682
Useless parentheses. 1693
Useless parentheses. 1697
These nested if statements could be combined 1708–1714
Useless qualified this usage in the same class. 1710

org/apache/log4j/chainsaw/LoggerNameListener.java

Violation Line
Avoid modifiers which are implied by the context 35
Avoid modifiers which are implied by the context 40

org/apache/log4j/chainsaw/LoggerNameModel.java

Violation Line
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 56
Avoid modifiers which are implied by the context 58
Avoid modifiers which are implied by the context 59

org/apache/log4j/chainsaw/LoggerNameTreePanel.java

Violation Line
Useless parentheses. 201
Useless parentheses. 202
Useless parentheses. 203
Useless parentheses. 208
Useless parentheses. 367
Useless parentheses. 368
Useless parentheses. 610
Useless parentheses. 610
Useless parentheses. 710
Useless parentheses. 710
Useless parentheses. 1118
Useless parentheses. 1118
Useless parentheses. 1338
Useless parentheses. 1338
Useless parentheses. 1391
Useless parentheses. 1391
Useless parentheses. 1391
Useless parentheses. 1394
Useless parentheses. 1394
Useless parentheses. 1394
Avoid empty if statements 1400–1401
Avoid empty if statements 1682–1685
Useless parentheses. 1785
Useless parentheses. 1786
Useless parentheses. 1787
Useless parentheses. 1794
Useless parentheses. 1795
Useless parentheses. 1879
Useless parentheses. 1880
Useless parentheses. 1900
Useless parentheses. 1901
Useless parentheses. 1902
Useless parentheses. 1907
Useless parentheses. 1911

org/apache/log4j/chainsaw/NewKeyListener.java

Violation Line
Avoid modifiers which are implied by the context 34

org/apache/log4j/chainsaw/SavableTabSetting.java

Violation Line
Avoid unused private fields such as 'dragdrop'. 29

org/apache/log4j/chainsaw/ShutdownListener.java

Violation Line
Avoid modifiers which are implied by the context 37

org/apache/log4j/chainsaw/TableColorizingRenderer.java

Violation Line
Avoid empty catch blocks 681–683

org/apache/log4j/chainsaw/ThrowableRenderPanel.java

Violation Line
Useless parentheses. 91

org/apache/log4j/chainsaw/color/ColorPanel.java

Violation Line
Useless parentheses. 312
Useless parentheses. 609
Useless parentheses. 609
Useless parentheses. 612
Useless parentheses. 612
Useless parentheses. 615
Useless parentheses. 660
Useless parentheses. 660
Useless parentheses. 723
Useless parentheses. 723
Useless parentheses. 779
Useless parentheses. 940

org/apache/log4j/chainsaw/color/Colorizer.java

Violation Line
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 43

org/apache/log4j/chainsaw/color/RuleColorizer.java

Violation Line
Useless parentheses. 185
Useless parentheses. 185
Useless parentheses. 202
Useless parentheses. 202
Avoid empty catch blocks 278–279

org/apache/log4j/chainsaw/help/HelpManager.java

Violation Line
Avoid empty catch blocks 68–70

org/apache/log4j/chainsaw/helper/SwingHelper.java

Violation Line
Useless parentheses. 59
Useless parentheses. 60

org/apache/log4j/chainsaw/icons/LineIconFactory.java

Violation Line
Useless parentheses. 69
Useless parentheses. 70
Useless parentheses. 74
Useless parentheses. 101
Useless parentheses. 102

org/apache/log4j/chainsaw/messages/MessageCenter.java

Violation Line
Useless parentheses. 162
Useless parentheses. 250

org/apache/log4j/chainsaw/prefs/Profileable.java

Violation Line
Avoid modifiers which are implied by the context 37

org/apache/log4j/chainsaw/prefs/SettingsListener.java

Violation Line
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 54

org/apache/log4j/chainsaw/prefs/SettingsManager.java

Violation Line
Avoid empty catch blocks 72–73

org/apache/log4j/chainsaw/receivers/PluginPropertyEditorPanel.java

Violation Line
Avoid empty catch blocks 156–158
Avoid empty catch blocks 365–367
Useless parentheses. 384
Useless parentheses. 385

org/apache/log4j/chainsaw/receivers/ReceiversHelper.java

Violation Line
Useless parentheses. 93

org/apache/log4j/chainsaw/receivers/ReceiversPanel.java

Violation Line
Useless parentheses. 199
Useless parentheses. 199
Useless parentheses. 200
Useless parentheses. 498
Useless parentheses. 537
Useless parentheses. 556
Useless parentheses. 600

org/apache/log4j/chainsaw/vfs/VFSLogFilePatternReceiverBeanInfo.java

Violation Line
Avoid empty catch blocks 51–52

org/apache/log4j/db/ConnectionSource.java

Violation Line
Avoid modifiers which are implied by the context 36
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 68

org/apache/log4j/db/CustomSQLDBReceiver.java

Violation Line
Useless parentheses. 173
Avoid empty catch blocks 198–200
Useless parentheses. 229
Useless parentheses. 344
Useless parentheses. 345
Useless parentheses. 377
Useless parentheses. 378
Avoid empty catch blocks 396–397

org/apache/log4j/db/DBAppender.java

Violation Line
Useless parentheses. 184
Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 251

org/apache/log4j/db/DBHelper.java

Violation Line
Avoid empty catch blocks 53–56
Avoid empty catch blocks 64–65

org/apache/log4j/db/DBReceiverJob.java

Violation Line
Avoid empty catch blocks 160–162

org/apache/log4j/db/dialect/SQLDialect.java

Violation Line
Avoid modifiers which are implied by the context 25

org/apache/log4j/db/dialect/Util.java

Violation Line
Avoid empty catch blocks 60–62

org/apache/log4j/helpers/MessageFormatter.java

Violation Line
Useless parentheses. 69
Useless parentheses. 76
Useless parentheses. 76
Useless parentheses. 122
Useless parentheses. 135

org/apache/log4j/net/JMSReceiver.java

Violation Line
Useless parentheses. 173–175
Avoid empty catch blocks 243–245
Avoid empty catch blocks 263–265

org/apache/log4j/net/JMSReceiverBeanInfo.java

Violation Line
Avoid empty catch blocks 47–48

org/apache/log4j/net/MulticastAppender.java

Violation Line
Avoid unused imports such as 'java.util.Hashtable' 26

org/apache/log4j/net/MulticastReceiver.java

Violation Line
Avoid empty catch blocks 266–268

org/apache/log4j/net/MulticastReceiverBeanInfo.java

Violation Line
Avoid empty catch blocks 46–47

org/apache/log4j/net/SocketHubReceiver.java

Violation Line
Useless parentheses. 225–228

org/apache/log4j/net/SocketNode13.java

Violation Line
Useless parentheses. 181
Avoid empty if statements 199–201
Avoid empty catch blocks 224–226

org/apache/log4j/net/SocketReceiver.java

Violation Line
Useless parentheses. 142
Useless parentheses. 145
Avoid empty catch blocks 215–217
Avoid empty catch blocks 229–231

org/apache/log4j/net/UDPReceiver.java

Violation Line
Avoid empty catch blocks 271–273

org/apache/log4j/net/XMLSocketNode.java

Violation Line
Useless parentheses. 108
Useless parentheses. 108
Avoid empty catch blocks 196–198

org/apache/log4j/net/XMLSocketReceiver.java

Violation Line
Useless parentheses. 128
Useless parentheses. 131
Ensure you override both equals() and hashCode() 137
Avoid empty catch blocks 221–223
Avoid empty catch blocks 235–237

org/apache/log4j/plugins/PluginSkeleton.java

Violation Line
Useless parentheses. 129
Useless parentheses. 130
Useless parentheses. 131–132

org/apache/log4j/plugins/Receiver.java

Violation Line
Useless parentheses. 102–103
Useless parentheses. 102

org/apache/log4j/varia/LogFilePatternReceiver.java

Violation Line
Avoid empty catch blocks 223–225
These nested if statements could be combined 536–538
These nested if statements could be combined 556–558
These nested if statements could be combined 574–576
These nested if statements could be combined 592–594
Useless parentheses. 593
Avoid unnecessary temporaries when converting primitives to Strings 719
Avoid unnecessary temporaries when converting primitives to Strings 740
Useless parentheses. 774
Useless parentheses. 927
These nested if statements could be combined 956–961
Useless parentheses. 990
Useless parentheses. 990
Useless parentheses. 990
Useless parentheses. 991

org/apache/log4j/varia/LogFilePatternReceiverBeanInfo.java

Violation Line
Avoid empty catch blocks 49–50

org/apache/log4j/xml/LogFileXMLReceiver.java

Violation Line
These nested if statements could be combined 153–155
Useless parentheses. 154

org/apache/log4j/xml/UtilLoggingXMLDecoder.java

Violation Line
Useless parentheses. 419
Useless parentheses. 420
Useless parentheses. 421
Useless parentheses. 422
Useless parentheses. 460
Useless parentheses. 461

org/apache/log4j/xml/XMLDecoder.java

Violation Line
Useless parentheses. 437
Useless parentheses. 438
Useless parentheses. 439
Useless parentheses. 440
Useless parentheses. 487
Useless parentheses. 488